feat: Make writeTimeout configurable (similar to readTimeout) #900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
lahirumaramba
approved these changes
May 14, 2024
egilmorez
approved these changes
May 14, 2024
| @@ -207,6 +210,16 @@ public int getReadTimeout() { | |||
| return readTimeout; | |||
| } | |||
|
|
|||
| /** | |||
| * Returns the write timeout in milliseconds, which is applied to outgoing REST calls | |||
There was a problem hiding this comment.
Since this is a case for "that" instead of which, let's just rephrase to something like:
"Returns the write timeout applied to outgoing REST calls in milliseconds."
If you think we can go ahead and assume "by the SDK."
lahirumaramba
changed the title
lahirumaramba
added a commit
that referenced
this pull request
May 15, 2024
Address TW reviews in #900
Merged
lahirumaramba
added a commit
that referenced
this pull request
May 16, 2024
lahirumaramba
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #850